From fe2ab3cae0d2337634a8033dfa41cc8151ef1b8e Mon Sep 17 00:00:00 2001 From: John Snow Date: Thu, 29 Sep 2016 05:11:02 +0200 Subject: [PATCH 1/6] ide: fix halted IO segfault at reset RH-Author: John Snow Message-id: <1475104263-20809-2-git-send-email-jsnow@redhat.com> Patchwork-id: 72433 O-Subject: [RHEV-7.3.z qemu-kvm-rhev PATCH 1/2] ide: fix halted IO segfault at reset Bugzilla: 1393043 RH-Acked-by: Laszlo Ersek RH-Acked-by: Paolo Bonzini RH-Acked-by: Markus Armbruster If one attempts to perform a system_reset after a failed IO request that causes the VM to enter a paused state, QEMU will segfault trying to free up the pending IO requests. These requests have already been completed and freed, though, so all we need to do is NULL them before we enter the paused state. Existing AHCI tests verify that halted requests are still resumed successfully after a STOP event. Analyzed-by: Laszlo Ersek Reviewed-by: Laszlo Ersek Signed-off-by: John Snow Message-id: 1469635201-11918-2-git-send-email-jsnow@redhat.com Signed-off-by: John Snow (cherry picked from commit 87ac25fd1fed05a30a93d27dbeb2a4c4b83ec95f) Signed-off-by: John Snow Signed-off-by: Miroslav Rezanina --- hw/ide/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index 4057924..4a6adbc 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -807,6 +807,7 @@ static void ide_dma_cb(void *opaque, int ret) } if (ret < 0) { if (ide_handle_rw_error(s, -ret, ide_dma_cmd_to_retry(s->dma_cmd))) { + s->bus->dma->aiocb = NULL; return; } } -- 1.8.3.1